Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Improper pathname parsing in nspawn function #38

Open
gitaalekhyapaul opened this issue May 13, 2021 · 1 comment · May be fixed by #39
Open

Bug: Improper pathname parsing in nspawn function #38

gitaalekhyapaul opened this issue May 13, 2021 · 1 comment · May be fixed by #39

Comments

@gitaalekhyapaul
Copy link

Bug Description:

The pathname parsing in nspawn function does not take into consideration spaces in the pathname.

Consider the following pathname of a CLI application: /home/user/Project Folder/Sub Folder/bin/cli (note the spaces in the pathname)

In the lines 360-362 in nexpect.js, we can see the following code:

Screenshot from 2021-05-13 17-29-03

Suppose we consider our above pathname, we can clearly observe:

  • command will be: /home/user/Project
  • params will be: params OR [ "Folder/Sub" , "Folder/bin/cli" ]

This leads to improper pathanme parsing and errors in testing.

Expected Behaviour:

The pathname should be parsed properly even if it contains spaces in it.

@gitaalekhyapaul gitaalekhyapaul linked a pull request May 13, 2021 that will close this issue
@gitaalekhyapaul
Copy link
Author

A detailed description of this issue can be found here: aws-amplify/amplify-cli#7324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant