Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on wrong engine version #504

Open
julianduque opened this issue Jul 16, 2014 · 5 comments
Open

Warn on wrong engine version #504

julianduque opened this issue Jul 16, 2014 · 5 comments

Comments

@julianduque
Copy link
Contributor

Currently the error isn't clear and get people confused, we should add a warning when user have wrong or unsupported engine version on package.json

@kdamball
Copy link

Current fix is to declare the engine as "0.10.x" in package.json

{
    "engines": {
        "node": "0.10.x"
    }
}

@baer
Copy link

baer commented Oct 6, 2014

I just experienced this and it's not that the error isn't clear - it just doesn't exist. I'm actually not clear on whether or not you can pin node versions at all...

...
info:    Creating snapshot 4.15.0-10
info:    Uploading: [=============================] 100%
error:   Error running command deploy
error:   Error building snapshot
error:   Nodejitsu Error (500): Internal Server Error
help:    For help with this error contact Nodejitsu Support:
help:      webchat: <http://webchat.nodejitsu.com/>
help:          irc: <irc://chat.freenode.net/#nodejitsu>
help:        email: <support@nodejitsu.com>
help:
help:      Copy and paste this output to a gist (http://gist.github.com/)
info:    Nodejitsu not ok

@kdamball
Copy link

kdamball commented Oct 6, 2014

@baer Did you change the version in package.json?

@baer
Copy link

baer commented Oct 6, 2014

@kdamball - Yes I changed to 0.10.x and things worked just fine but I had to go to the IRC room to figure that out since there was no warning, logfile or error that I could see indicating the issue.

Side note, Semver is far from perfect and I have had to pin versions in node before - seems like the real fix would be to allow users to run whatever version of node they like.

@kdamball
Copy link

kdamball commented Oct 6, 2014

seems like the real fix would be to allow users to run whatever version of node they like.

You're onto something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants