Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tests to TypeScript #9

Open
from-the-river-to-the-sea opened this issue Apr 20, 2019 · 0 comments
Open

Convert tests to TypeScript #9

from-the-river-to-the-sea opened this issue Apr 20, 2019 · 0 comments

Comments

@from-the-river-to-the-sea
Copy link
Contributor

Our tests are in raw JS right now, which means they aren't really testing our types, and they're a bit harder to write due to not having TS autocomplete.

We should re-write them in TS, and also ensure that we are applying the obs-websocket-js typedefs to our mock-obs-websocket-js, to ensure that our mock is the right shape.

See https://github.com/Tespa/hearthstone-parser for an example of how I like to handle tests in TypeScript (although that repo uses Mocha, not Ava, so it's not a 1:1 example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant