Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.7.0: punycode is deprecated in 'whatwg-url' and 'tr46' #1794

Closed
riprsa opened this issue Dec 6, 2023 · 3 comments
Closed

v2.7.0: punycode is deprecated in 'whatwg-url' and 'tr46' #1794

riprsa opened this issue Dec 6, 2023 · 3 comments
Labels

Comments

@riprsa
Copy link

riprsa commented Dec 6, 2023

Reproduction

Steps to reproduce the behavior:

Using node v21.2.0:

package.json:

{
    "dependencies": {
        "node-fetch": "^2.7.0"
    }
}

index.js:

const fetch = require('node-fetch');
fetch("https://google.com").then((res) => {
    console.log(res.status);
});

output:

(node:25053) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
200

Expected behavior

Lack of deprecation note

Your Environment

software version
node-fetch 2.7.0
node 21.2.0
npm 10.2.3
Operating System macOS
@riprsa riprsa added the bug label Dec 6, 2023
@jimmywarting
Copy link
Collaborator

see: #1793 (comment)

@erictheswift
Copy link

See line 40 at https://www.npmjs.com/package/node-fetch/v/2.7.0?activeTab=code
Seems wrong package.json was published, thus this issue is not resolved

@erictheswift
Copy link

Ah ok, there's an ongoing issue about that #1797 @jimmywarting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants