Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔦 Feature: Open file in attachment in the browser like we do for images #8304

Open
1 task done
o1lab opened this issue Apr 19, 2024 · 2 comments
Open
1 task done
Assignees

Comments

@o1lab
Copy link
Member

o1lab commented Apr 19, 2024

Please confirm if feature request does NOT exist already ?

  • I confirm there is no existing issue for this

Describe the usecase for the feature

File types like pdf, docs are getting downloaded. Instead, they should open in the browser itself.

Suggested Solution

.

Additional Context

No response

@salim-b
Copy link
Contributor

salim-b commented Apr 22, 2024

File types like pdf, docs are getting downloaded. Instead, they should open in the browser itself.

For PDFs, this is not true – they don't get downloaded but opened in new browser tabs / pop-up windows without getting downloaded in the common sense (technically they are downloaded to the browser cache of course, but not a user directory like ~/Downloads). Tested with NocoDB 0.205.1 and Firefox and Chrome/Chromium on Linux (Ubuntu 22.04).

But the attachment file handling could certainly be improved! A few suggestions:

  1. Allow "bulk deletion". The UI already allows to select multiple attachments, but currently the only action available then is Bulk Download. It would be great to also have Bulk Delete.

    Furthermore, I'd suggest to use slightly different, more intuitive terms: Download selection and Delete selection.

  2. The current attachment download functionality is a bit misleading as it actually doesn't download an attachment (in the common sense) but rather opens it in a new tab. Thus I think download should do what a regular user would expect, i.e. save the attachment to disk (to the user's ~/Downloads directory or whatever is configured in the user's browser settings).

    Additionally, there could still be an Open in new tab action if that is desired.

  3. The current Bulk Download action opens the first selected attachment in a new tab and the remaining ones in pop-up windows – which requires the user to first allow pop-ups for the NocoDB hostname. This is a subpar UX. Instead,

    • Bulk Download (or Download selection) should actually download the selected files to disk as outlined above.
    • a possibly new Open selection in new tabs action should open all attachments in new tabs (if that's possible browser-API-wise, I dunno).

@dstala
Copy link
Member

dstala commented May 18, 2024

On MAC OS

  • Chrome : file gets downloaded
  • Firefox : file gets opened in adjacent tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏌️ Open
Development

No branches or pull requests

4 participants