Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Primary key shouldn't be deleted manually. #8236

Open
1 task done
TangXY123 opened this issue Apr 10, 2024 · 3 comments · May be fixed by #8285
Open
1 task done

🐛 Bug: Primary key shouldn't be deleted manually. #8236

TangXY123 opened this issue Apr 10, 2024 · 3 comments · May be fixed by #8285
Assignees
@sreehari2003
Labels
Status: Reproducible Able to reproduce the issue based on the reporters' guideline.

Comments

@TangXY123
Copy link

Please confirm if bug report does NOT exist already ?

  • I confirm there is no existing issue for this

Steps to reproduce ?

  • The table's System Fields can be hidden or shown, and system fields can be also deleted! Although system fields can not be edited.
    image
  • If users delete the Id, which is the primary key of the table, the system will throw out Error: "Update not allowed for table which doesn't have primary key."
    image
    image
  • This is not reasonable. System fields can be shown, but cannot be deleted or edited, I think.

Desired Behavior

x

Project Details

  • docker build
  • version 0.205.0
  • mysql8.0

Attachments

No response
@dstala
Copy link
Member

dstala commented Apr 10, 2024

Agree. Works that way with PG. Need to disable delete button in general for system fields to avoid any confusion.

@dstala dstala added the Status: Reproducible Able to reproduce the issue based on the reporters' guideline. label Apr 10, 2024
@sreehari2003
Copy link
Contributor

sreehari2003 commented Apr 15, 2024 •
edited

@dstala can I work on this? I can remove the delete button for system fields.

@dstala
Copy link
Member

dstala commented Apr 16, 2024

@sreehari2003 assigned

@sreehari2003 sreehari2003 linked a pull request Apr 16, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreehari2003 sreehari2003

Labels
Status: Reproducible Able to reproduce the issue based on the reporters' guideline.
Projects
🚀 NocoDB: Issue Board
Status: 🏌️ Open
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent system fields from getting deleted manually sreehari2003/nocodb
3 participants
@TangXY123 @sreehari2003 @dstala