Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from nnsvs.train_util import NpyFileSource #169

Open
SouperDuper opened this issue Nov 19, 2022 · 1 comment
Open

from nnsvs.train_util import NpyFileSource #169

SouperDuper opened this issue Nov 19, 2022 · 1 comment
Assignees
@r9y9
Labels
bug Something isn't working

Comments

@SouperDuper
Copy link

SouperDuper commented Nov 19, 2022 •
edited

generate.py tries to import NpyFileSource from train_util.py but this was removed in commit 3f7e37a0da34273fcfed70a4409fd8456fd776c9

I understand the generate step is not required but it may be confusing to some. Thank you.
@r9y9 r9y9 added the bug Something isn't working label Nov 20, 2022
@r9y9 r9y9 added this to the v0.1.0 release milestone Nov 21, 2022
@r9y9 r9y9 self-assigned this Nov 21, 2022
@r9y9
Copy link
Collaborator

r9y9 commented Nov 21, 2022

Thanks for pointing this out. I agree it may be confusing. The generate.py will not be used in the future version anymore. I'll add a property fix at some point.

@r9y9 r9y9 removed this from the v0.1.0 release milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r9y9 r9y9

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r9y9 @SouperDuper