Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

niv update doesn't update the description and homepage #358

Open
akshaymankar opened this issue Nov 8, 2022 · 1 comment
Open

niv update doesn't update the description and homepage #358

akshaymankar opened this issue Nov 8, 2022 · 1 comment

Comments

@akshaymankar
Copy link

akshaymankar commented Nov 8, 2022

Sometimes forks use descriptions in github which explain the need for the fork, when the need is over one can go back to using the upstream repository by running niv update <name> -o <upstream> -b <upstream-branch>. This does not update the description and the homepage field in nix/sources.json. It would be nice if niv took care of these things when the owner was changed.

akshaymankar added a commit to wireapp/wire-server that referenced this issue Nov 8, 2022
@akshaymankar akshaymankar changed the title niv update doesn't update the description niv update doesn't update the description and homepage Nov 8, 2022
akshaymankar added a commit to wireapp/wire-server that referenced this issue Nov 8, 2022
@nmattia
Copy link
Owner

nmattia commented Nov 8, 2022

Thanks for the report!

Updating description and homepage requires calls to the GitHub API, which niv tries to avoid as much as possible (instead using only git calls when possible). I think it could make sense though! I'm not actively working on niv anymore but if someone's willing to submit the feature I'm happy to give pointers.

akshaymankar added a commit to wireapp/wire-server that referenced this issue Nov 8, 2022
* Bump nixpkgs to latest unstable, stop using forked nixpkgs

* Use openssl 3.0.7 for HsOpenSSL

Latest nixpkgs unstable contains the fixed version of openssl.

* nix/sources.json: Update description and homepage

`niv update` misses this: nmattia/niv#358
supersven pushed a commit to wireapp/wire-server that referenced this issue Nov 22, 2022
* Bump nixpkgs to latest unstable, stop using forked nixpkgs

* Use openssl 3.0.7 for HsOpenSSL

Latest nixpkgs unstable contains the fixed version of openssl.

* nix/sources.json: Update description and homepage

`niv update` misses this: nmattia/niv#358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants