Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaro-Winkler Distance in nltk.metrics.distance #2006

Closed
znd4 opened this issue Apr 19, 2018 · 3 comments
Closed

Jaro-Winkler Distance in nltk.metrics.distance #2006

znd4 opened this issue Apr 19, 2018 · 3 comments
Labels
resolved

Comments

@znd4
Copy link

znd4 commented Apr 19, 2018

Hi, I think it would be awesome to have Jaro Winkler Distance implemented in nltk.metrics.distance. I'd love to take a crack at it if there's no one currently working on it. There are a number of projects online implementing this, but NLTK seems like the right larger project that should have this implemented.
@53X
Copy link
Contributor

53X commented Apr 22, 2018

Working on it currently . I will make the PR soon . 😄

@53X 53X mentioned this issue Jun 12, 2018
Merged
@53X
Copy link
Contributor

53X commented Jun 12, 2018

@zdog234 , @alvations , @stevenbird I made the PR here

@alvations
Copy link
Contributor

alvations commented Jul 26, 2018 •
edited

Thanks again @53X for the contribution! Resolved in #2044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alvations @znd4 @53X