Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextTiling not support python 3 #1861

Closed
talbaumel opened this issue Oct 16, 2017 · 4 comments
Closed

TextTiling not support python 3 #1861

talbaumel opened this issue Oct 16, 2017 · 4 comments

Comments

@talbaumel
Copy link

In line 315 clip = min(max(len(scores)/10, 2), 5) you should wrap this value with a int because python 3 division type is float.

Thanks

@alvations alvations added this to the 3.2.6 milestone Oct 16, 2017
@alvations
Copy link
Contributor

Related #965 #1537 and https://github.com/nltk/nltk/issues?utf8=✓&q=is%3Aissue%20is%3Aopen%20texttiling

I think this is a long standing bug that hasn't been fixed and the fix could be pretty simple. Let's try to patch this by the next release ;P

@zorroblue
Copy link

I would like to work on this :)

@e5pecial
Copy link
Contributor

#1863
This bug was fixed :)

@alvations
Copy link
Contributor

alvations commented Oct 23, 2017

@e5pecial Thanks for the note!

@zorroblue Thank you for your interest, if you're up to contribute on something else, you can try browsing the goodfirstbug tag: https://github.com/nltk/nltk/labels/goodfirstbug . Or if you're interested to work on the related issues, there's #965 and #1537.

Resolved in #1863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants