Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility fix for Gnome 46 #103

Closed
mendres82 opened this issue Mar 23, 2024 · 12 comments
Closed

Compatibility fix for Gnome 46 #103

mendres82 opened this issue Mar 23, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@mendres82
Copy link
Contributor

mendres82 commented Mar 23, 2024

Running this extension with Gnome 46 on openSUSE Tumbleweed gave me an error. Fortunately, it was quite easy to get around the issue. I just had to edit indicator.js and change lines 297 and 298 from add_actor to add_child .

@MorbidShell
Copy link

Sorry to butt in, but you could just make a pull request with the changes. :p

@mendres82
Copy link
Contributor Author

I created the pull request.

@cmeissner
Copy link

#104 works also with Fedora 40. After adjusting shell-version in metadata.json and re-login the extension works well

@OsoRojo
Copy link

OsoRojo commented May 12, 2024

While this fix works (changing lines 297 and 298 and fixing the shell-version in metadata.json), it seems to break session logout. When the logout dialog appears, clicking logout does nothing. You can still logout using gnome-session-quit -force, but that's not ideal. Disabling the extension restores normal logout behavior, so it does seem to be related to the extension.

@mendres82
Copy link
Contributor Author

..., it seems to break session logout. When the logout dialog appears, clicking logout does nothing. You can still logout using gnome-session-quit -force, but that's not ideal.

Cannot reproduce on openSUSE Tumbleweed (Gnome 46.1) and Slowroll (Gnome 46.0). Both on Wayland.

@OsoRojo
Copy link

OsoRojo commented May 13, 2024

..., it seems to break session logout. When the logout dialog appears, clicking logout does nothing. You can still logout using gnome-session-quit -force, but that's not ideal.

Cannot reproduce on openSUSE Tumbleweed (Gnome 46.1) and Slowroll (Gnome 46.0). Both on Wayland.

Just reproduced on a clean Fedora 40 Silverblue VM (Gnome 46.1 on Wayland) with no other extensions installed and the above mods in place. Note that the original report was not from Silverblue, but desktop proper with the same versions.

Disabling the plugin restores normal behavior.

Sorry, should have noted the distro I guess.

@nlpsuge
Copy link
Owner

nlpsuge commented May 18, 2024

While this fix works (changing lines 297 and 298 and fixing the shell-version in metadata.json), it seems to break session logout. When the logout dialog appears, clicking logout does nothing.

Hi, a new version that supports Gnome 46 has been approved, could you please test it again after updating? I think it might be fixed.

@OsoRojo
Copy link

OsoRojo commented May 18, 2024

So it's... sort of fixed, yes. I get the standard "you will be logged out after 60 seconds"...

image

And then after clicking logout via AWSM, I get this:

image

Clicking Logout Now DOES log me out, so that's good. But there are no other applications listed, and I don't have anything running but Software and Extensions. It's something I've never seen before.

To be clear, it's not a huge problem. It does allow both logout and reboot after it comes up, but the fact that no applications are listed seemed a bit odd. If this is just what we have to do now for some known reason I'm totally fine with that.

Thoughts?

@sadamczyk
Copy link

@OsoRojo I've had that exact same problem on Fedora 39 / Gnome 45 already and it's still the same after the update to Fedora 40 / Gnome 46, so I don't think this is anything new.
As you say, I always need to click "Log out now" / "Reboot now" manually.
If applications are still running, they get closed, but then the "Running applications" window just sits there doing nothing.

@nlpsuge nlpsuge added the bug Something isn't working label May 20, 2024
nlpsuge added a commit that referenced this issue May 20, 2024
… not a constructor', so that it won't prevent the system from logging out. Related to #103
@nlpsuge
Copy link
Owner

nlpsuge commented May 20, 2024

@sadamczyk @OsoRojo I've uploaded a new version that fixes the issue you mentioned. I'm waiting for it to be approved.

@nlpsuge nlpsuge closed this as completed May 21, 2024
@OsoRojo
Copy link

OsoRojo commented May 21, 2024

Verified fixed on clean Silverblue VM for both logout and reboot! Thank you!!

@sadamczyk
Copy link

Just updated and it's fixed for me as well. Thanks for the quick fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants