Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Titles are validating even without <!DOCTYPE html> #540

Open
oscarlcarlsson opened this issue Dec 20, 2022 · 4 comments
Open

Titles are validating even without <!DOCTYPE html> #540

oscarlcarlsson opened this issue Dec 20, 2022 · 4 comments

Comments

@oscarlcarlsson
Copy link
Collaborator

I just notices that files turn out as valid even though they are missing in the validator. I believe that this has been an issue for a long time, since several of our enriched files are missing it.
According to 2.5.1.2 Document Type Declaration in the 2020-1 guidelines, this is required.
Is this left out on purpose?
@josteinaj
Copy link
Member

Checking the doctype (or the XML declaration) is not possible using RelaxNG og Schematron. The validator that used XProc and Pipeline 2 used Java to extract the doctype and XML declaration, but also had a fallback to a pure XProc/XSLT implementation (although it was less efficient).

@kalaspuffar do you know if the doctype validation was copied over from the old code (or reimplemented)?

@kalaspuffar
Copy link
Collaborator

Hi.

We have added a card for this in Trello and will address it in the Prio order.

Best regards
Daniel

@oscarlcarlsson
Copy link
Collaborator Author

I just had a look at some files where was not included. and they still pass through the validator. Any thoughts on if this should be allowed or not?

@josteinaj
Copy link
Member

The XML and DOCTYPE declarations are required in the guidelines, so they should also be required in the validator. Both for 2015-1 and 2020-1.

@kalaspuffar kalaspuffar mentioned this issue Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josteinaj @kalaspuffar @oscarlcarlsson