-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that DTBook XML encoding value is UTF-8 #318
Comments
It stores it initially using us-ascii so that all non-ascii characters are hex encoded; then it should set the encoding in the xml declaration to utf-8. Is there any errors or warnings in the logs? |
No. So far I can't find anything in the logs. I've tried even to validate a dtbook with 'us-ascii' encoding using the Nordic script and no errors or warnings are shown. So it seems the files are correctly encoded but the us-ascii value still present in the encoding attr. |
ok, thanks. |
I'm not able to reproduce this. @TamJ: Which build of the migrator were you using? |
We experience still the same issue in build 314. Al html files in the epub3 are using encoding utf-8, but the generated DTBook output is in us-ascii encoding. |
I was not able to reproduce this earlier. @EdmarS: I will send you login info to our test-server. See if you can reproduce it there. |
Ok, we need to determine in what environment and for which books this issue occurs so that we can reproduce it. Here's some more detailed steps to collect information about the environment from a Windows install:
|
Anders (SPSM) was able to provide a log containing an exception. I would still like to get log files from others who experience this problem so that I can compare the environments, but in any case this at least shows us where in the code the problem lies:
So it attempts to change the encoding but fails because the file is already in use. It is unclear why this happens, so more debugging info (including answers to the questions I asked in the debugging instructions) is much appreciated. |
- enabled xprocspec tests in common-utils, file-utils, fileset-utils and zip-utils - added debug messages in Java to SetDoctype and SetXmlDeclaration - in SetDoctype and SetXmlDeclaration, make sure the new file is closed before moving it (might help with nlbdev/nordic-epub3-dtbook-migrator#318) - ability to force usage of XProc/XSLT implementation over Java implementation in px:copy-resource, px:file-peek, px:file-xml-peek, px:set-doctype and px:set-xml-declaration - added test for both Java and XProc/XSLT implementation of px:set-doctype - fixed xprocspec test for px:file-xml-peek - moved unzip-fileset, and its tests, from zip-utils to fileset-utils to avoid a circular dependency between the two modules - also cleaned up some of the related filenames and step names - ...such as: px:unzip-fileset are now called px:fileset-unzip and are available from fileset-utils instead of zip-utils - bumped minor version of fileset-utils since it now has new features
- enabled xprocspec tests in common-utils, file-utils, fileset-utils and zip-utils - added debug messages in Java to SetDoctype and SetXmlDeclaration - in SetDoctype and SetXmlDeclaration, make sure the new file is closed before moving it (might help with nlbdev/nordic-epub3-dtbook-migrator#318) - ability to force usage of XProc/XSLT implementation over Java implementation in px:copy-resource, px:file-peek, px:file-xml-peek, px:set-doctype and px:set-xml-declaration - added test for both Java and XProc/XSLT implementation of px:set-doctype - fixed xprocspec test for px:file-xml-peek - moved unzip-fileset, and its tests, from zip-utils to fileset-utils to avoid a circular dependency between the two modules - also cleaned up some of the related filenames and step names - ...such as: px:unzip-fileset are now called px:fileset-unzip and are available from fileset-utils instead of zip-utils - bumped minor version of fileset-utils since it now has new features
- enabled xprocspec tests in common-utils, file-utils, fileset-utils and zip-utils - added debug messages in Java to SetDoctype and SetXmlDeclaration - in SetDoctype and SetXmlDeclaration, make sure the new file is closed before moving it (might help with nlbdev/nordic-epub3-dtbook-migrator#318) - ability to force usage of XProc/XSLT implementation over Java implementation in px:copy-resource, px:file-peek, px:file-xml-peek, px:set-doctype and px:set-xml-declaration - added test for both Java and XProc/XSLT implementation of px:set-doctype - fixed xprocspec test for px:file-xml-peek - moved unzip-fileset, and its tests, from zip-utils to fileset-utils to avoid a circular dependency between the two modules - also cleaned up some of the related filenames and step names - ...such as: px:unzip-fileset are now called px:fileset-unzip and are available from fileset-utils instead of zip-utils - bumped minor version of fileset-utils since it now has new features
Unfortunately not fixed by v1.2.0. It's still the same exception in the logs as previously reported. |
Reported again today by Martin (MTM). We could possibly add a boolean option called for instance " |
It looks like the 'us-ascii' value is now being set as the xml encoding value. Maybe a bug from the latest xslt/xproc updates??
The text was updated successfully, but these errors were encountered: