Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy_nixos leaks files from the working directory into the world-readable nix store #67

Open
brainrake opened this issue Sep 21, 2022 · 0 comments

Comments

@brainrake
Copy link

brainrake commented Sep 21, 2022

Describe the bug
deploy_nixos evaulates an expression that has ./. as src and leaks the contents of the working directory into the world-readable nix store. The working directory may contain (.gitignored) secrets so this is a security issue.
https://github.com/tweag/terraform-nixos/blob/646cacb12439ca477c05315a7bfd49e9832bc4e3/deploy_nixos/nixos-instantiate.sh#L22

To Reproduce
Use deploy_nixos module

Expected behavior
Don't leak files from working directory.

Environment

  • OS name + version: NixOS unstable
  • Version of the code: 646cacb
@brainrake brainrake changed the title deploy_nixos leaks .gitignored files into the world-readable nix store deploy_nixos leaks files from the working directory into the world-readable nix store Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant