Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve revision when using submodules #338

Open
teto opened this issue Apr 28, 2024 · 0 comments
Open

resolve revision when using submodules #338

teto opened this issue Apr 28, 2024 · 0 comments

Comments

@teto
Copy link

teto commented Apr 28, 2024

I have started using nurl in luarocks-nix.

$ nurl https://github.com/teto/luabitop master -S

fetchFromGitHub {
  owner = "teto";
  repo = "luabitop";
  rev = "master";
  hash = "sha256-yLE198w1Ry4y9kflK/QHeWlmi0T7zJSie00UVgR/l54=";
  fetchSubmodules = true;
}

ofc it doesn't build

       last 13 log lines:
       > exporting https://github.com/teto/luabitop.git (rev master) into /nix/store/20zhsmkxm7nndlprrqbchknghjlz4cv1-source
       > Initialized empty Git repository in /nix/store/20zhsmkxm7nndlprrqbchknghjlz4cv1-source/.git/
       > fatal: couldn't find remote ref refs/tags/master
       > remote: Enumerating objects: 33, done.
       > remote: Counting objects: 100% (33/33), done.
       > remote: Compressing objects: 100% (29/29), done.
       > remote: Total 33 (delta 2), reused 22 (delta 2), pack-reused 0
       > Unpacking objects: 100% (33/33), 37.73 KiB | 402.00 KiB/s, done.
       > From https://github.com/teto/luabitop
       >  * branch            HEAD       -> FETCH_HEAD
       > fatal: Not a valid object name
       > Unrecognized git object type:
       > Unable to checkout refs/tags/master from https://github.com/teto/luabitop.git.
       For full logs, run 'nix log /nix/store/lmr3pxlqnd82169xlr7sdsb5ddq5nbvl-source.drv'.

would be nice if nurl could infer the revision. Related to #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant