Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans for V2 Macaroon support #7

Open
herrvendil opened this issue Feb 7, 2018 · 5 comments
Open

Any plans for V2 Macaroon support #7

herrvendil opened this issue Feb 7, 2018 · 5 comments

Comments

@herrvendil
Copy link

Hi

I use your project for parsing macaroons generated from an application that just switched to V2 Macaroons. Are there any plans for this project to support this in future?

Regards
Philip Vendil

@schmohlio
Copy link

I'm interested in helping

@nitram509
Copy link
Owner

Hi @herrvendil and @schmohlio,
as you might have already realized, I'm only looking occasionally into it. Fixing bugs (when reported, etc).
Every contribution is welcome, especially pull requests.
Besides that, I don't have an active roadmap nor further development plan.

@jaxley
Copy link
Contributor

jaxley commented Jul 24, 2019

The fork https://github.com/nickrobison-usds/jmacaroons has already implemented support for v2 macaroons it seems.

NeilMadden pushed a commit to NeilMadden/jmacaroons that referenced this issue Nov 27, 2019
@NeilMadden
Copy link
Contributor

I've raised a PR that implements V2 binary format. (I didn't see the fork, but that appears to have only implement V2 JSON format from a quick glance).

nitram509 added a commit that referenced this issue Dec 5, 2019
@nitram509
Copy link
Owner

Hi everyone,

the V2 support was contributed by Neil Madden and I'm glad to say: has landed in MASTER branch already.
I hope to get the release ready quite soon, so you could all expect a proper release on maven central.

Regards
Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants