Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case (in)sensitivity and/or regex-based searching #8

Open
berquist opened this issue Aug 22, 2017 · 2 comments
Open

Case (in)sensitivity and/or regex-based searching #8

berquist opened this issue Aug 22, 2017 · 2 comments

Comments

@berquist
Copy link

Uploading files from DALTON and then searching in the Package field for 'dalton' returned no hits. It would be nice to have an option for case-insensitive or regex-based search for all the fields

@nitish6174
Copy link
Owner

Thank you for bringing this up!
As for package name, I hope case-insensitive search will suffice and fuzzy matching to take care of slight spelling differences. Or infact, simply having checkboxes for each available package name will make more sense and easier to use.
Any other ideas for package field?

For the molecular formula, I have planned a regex-type search allowing queries like CH3(CH2)*CH3, C{4,6}H{10,14} etc.
For now, it just allows a very rigid syntax pattern like H 6 C 6 (similar to what is being used in URL when browsing molecules).

@berquist
Copy link
Author

I think case-insensitive and fuzzy search is fine. Checkboxes would work, since the number is finite, but it's another thing that would need to be modified in the future if we add parsers, and personally I'd rather type than click around.

I also think that's perfectly flexible for the molecule search, where it makes more sense to have a regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants