Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise InputMultiObject of the BSpline interface #386

Open
oesteban opened this issue Aug 16, 2023 · 1 comment
Open

Revise InputMultiObject of the BSpline interface #386

oesteban opened this issue Aug 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@oesteban
Copy link
Member

oesteban commented Aug 16, 2023

See https://github.com/nipreps/sdcflows/pull/346/files#r1294641020

@effigies
Copy link
Member

effigies commented Oct 2, 2023

Noting that this is specifically about these inputs, since following this link is a little messy:

fmap2data_xfm = InputMultiObject(
File(exists=True),
desc="the transform by which the target EPI can be resampled on the fieldmap's grid.",
xor="data2fmap_xfm",
)
data2fmap_xfm = InputMultiObject(
File(exists=True),
desc="the transform by which the fieldmap can be resampled on the target EPI's grid.",
xor="fmap2data_xfm",
)

Seems confusing making these MultiObjects, since the first is always being used and the rest discarded - and we should specify that these need to be in ITK format.

This is for compatiblity with the nipype interface. We probably want not to drop linear transforms after the first, although it feels like a rabbit hole.

So, rather than operating here, I think we want to open an issue to think about how a list here should be managed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants