Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise tolerance of sdcflows/interfaces/tests/test_bspline.py::test_bsplines #369

Open
oesteban opened this issue Jul 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@oesteban
Copy link
Member

oesteban commented Jul 3, 2023

What happened?

While debugging #346, and after incorporating #368, I discovered that the intermediate results of sdcflows/interfaces/tests/test_bspline.py::test_bsplines didn't make any sense (see commit comment of 6678591 ).

After that commit (6678591), the intermediate results make more sense, but I had to raise the tolerance of the test to 25Hz of error, which may (or may not) be too much.

This test should be revised and determine whether the tolerance of 25 Hz is acceptable.

What command did you use?

pytest sdcflows/interfaces/tests/test_bspline.py::test_bsplines[0]

What version of the software are you running?

latest

How are you running this software?

Local installation ("bare-metal")

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant