Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-alphanumeric characters from workflow names and output entities #434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tsalo
Copy link
Contributor

@tsalo tsalo commented Apr 2, 2024

Closes #295.

Changes proposed:

  • Use regular expressions to remove non-alphanumeric characters from the B0FieldIdentifier used in workflow names and output entities.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.41%. Comparing base (2456489) to head (a18cdb2).

Files Patch % Lines
sdcflows/workflows/fit/base.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   76.43%   76.41%   -0.03%     
==========================================
  Files          32       32              
  Lines        2835     2841       +6     
  Branches      376      376              
==========================================
+ Hits         2167     2171       +4     
- Misses        600      602       +2     
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

B0FieldIdentifier: some characters should be replaced to set workflow name to avoid crashes in graph creation
1 participant