Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwarp workflow | Generate fieldmap and fieldwarp in "un-HMC'd" coordinates #245

Open
oesteban opened this issue Oct 20, 2021 · 0 comments
Open

Unwarp workflow | Generate fieldmap and fieldwarp in "un-HMC'd" coordinates #245

oesteban opened this issue Oct 20, 2021 · 0 comments
Assignees
@oesteban
Labels
bug Something isn't working effort: medium Estimated medium effort task impact: high Estimated high impact task unwarping

Comments

@oesteban
Copy link
Member

oesteban commented Oct 20, 2021 •
edited

Currently fMRIPrep downstream nodes do not understand that a fieldwarp per timepoint is generated, and therefore it picks up only the first.

This is incorrect because we don't use the first frame as the reference for HMC.

The unwarp workflow should have two additional outputs with the fieldmap and fieldwarp in boldref's coordinates.
@oesteban oesteban changed the title Unwarp workflow Generate fieldmap and fieldwarp in "un-HMC'd" coordinates Unwarp workflow | Generate fieldmap and fieldwarp in "un-HMC'd" coordinates Oct 20, 2021
@oesteban oesteban self-assigned this Oct 20, 2021
@oesteban oesteban added bug Something isn't working effort: medium Estimated medium effort task impact: high Estimated high impact task unwarping labels Oct 20, 2021
oesteban added a commit to nipreps/fmriprep that referenced this issue Oct 20, 2021
@oesteban
fix: propagate the SDC warp to resampling node also with ME
8216eb1 
This connection can (should) be shared by both the SE and the ME paths.
That said, SDCFlows needs to be revised (nipreps/sdcflows#245) so that
fieldmaps without HMC are generated (and remove that ``_pop`` from this
connection).

Ammends: #2576.
@oesteban oesteban mentioned this issue Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oesteban oesteban

Labels
bug Something isn't working effort: medium Estimated medium effort task impact: high Estimated high impact task unwarping
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oesteban