Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRIQC doesn't like relative paths: Can error be thrown right away? #689

Closed
nicholst opened this issue Feb 14, 2018 · 4 comments
Closed

MRIQC doesn't like relative paths: Can error be thrown right away? #689

nicholst opened this issue Feb 14, 2018 · 4 comments

Comments

@nicholst
Copy link
Contributor

In my first mriqc run, I found that a relative path failed to work. I.e. with this run:

docker run -it --rm -v BIDS:/data:ro -v BIDSmriqc:/out poldracklab/mriqc:latest /data /out participant 

I got errors

2018-02-13 20:31:15,018 mriqc.cli:WARNING No T1w scans were found in /data
2018-02-13 20:31:15,019 mriqc.cli:WARNING No bold scans were found in /data
2018-02-13 20:31:15,019 mriqc.cli:WARNING No T2w scans were found in /data

BIDS is in fact a just-validated BIDS directory and had T1w and bold files; so I tried

docker run -it --rm -v $PWD/BIDS:/data:ro -v BIDSmriqc:/out poldracklab/mriqc:latest /data /out participant

and it ran. At the end, with the log suggesting all is honky dory, with lines like

2018-02-14 00:07:26,983 niworkflows:INFO Generating visual report
2018-02-14 00:07:43,637 niworkflows:INFO Successfully created report (/usr/local/src/mriqc/work/workflow_enumerator/funcMRIQC/SpatialNormalization/_in_file_..data..sub-03..func..sub-03_task-FacesHappy_bold.nii.gz/EPI2MNI/report.svg)

actually... nothing. There was no BIDSmriqc output folder.

I presume if I re-run (and wait another 9 hours) I may hope for a result if I replace BIDSmriqc with $PWD/BIDSmriqc but it would be really nice if

  1. The documentation can be updated, if this is correct, that relative paths cannot be used with docker and,
  2. If there was some sort of prospective error to warn me that output is actually going to /dev/null (an error is generated for /data, so can't it be generated for /out?)

Tnx!

@chrisgorgo
Copy link
Collaborator

Sorry for this. This is a Docker issue (see moby/moby#4830 (comment)). Not sure we would be able to detect this from within the container, but we should definitely update the documentation.

@nicholst
Copy link
Contributor Author

I created a PR for the docs to address this #690; this issue could be closed.

@chrisgorgo
Copy link
Collaborator

FYI - I checked the --mount option (which gives better errors than -v), but it does not work on Windows.

@oesteban
Copy link
Member

Closing after #690 was merged. Thanks @nicholst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants