Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report clearly bids filters #3095

Open
celprov opened this issue Sep 27, 2023 · 3 comments
Open

Report clearly bids filters #3095

celprov opened this issue Sep 27, 2023 · 3 comments
Labels
documentation effort: low Estimated low effort task good first issue impact: medium Estimated medium impact task

Comments

@celprov
Copy link
Contributor

celprov commented Sep 27, 2023

What would you like to see added in fMRIPrep?

It would be nice that the bids filters were reported very clearly in the log file (and perhaps make them also appear in the config)

cc/ @oesteban

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

No response

@celprov celprov changed the title Report clearly bids filters in the log file Report clearly bids filters Sep 27, 2023
@oesteban oesteban added documentation good first issue impact: medium Estimated medium impact task effort: low Estimated low effort task labels Sep 27, 2023
@oesteban
Copy link
Member

cc/ @bpinsard - I think I remember he implemented the earliest version of filters?

@effigies
Copy link
Member

They should appear in config.execution.bids_filters. Unless you mean you want the final filters, when merged with the default filters, i.e., the queries variable at the end of:

https://github.com/nipreps/niworkflows/blob/master/niworkflows/utils/bids.py#L228-L244

@bpinsard
Copy link
Collaborator

I confirm that the filters do appear in the config.toml.
Logging the final one should be easy to implement.
Adding these to the html reports might require more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation effort: low Estimated low effort task good first issue impact: medium Estimated medium impact task
Projects
None yet
Development

No branches or pull requests

4 participants