Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LyricsPlus buttons from disappearing behind player bar #290

Closed
wants to merge 2 commits into from

Conversation

9hax
Copy link

@9hax 9hax commented Jul 17, 2023

This fixes #285 and tackles one of the issues in #288

@9hax
Copy link
Author

9hax commented Jul 17, 2023

Before-Images can be found in the linked issues.

After for #285:
image
Notice that the text "Lyrics provided by Netease" and the four LyricsPlus buttons are visible.

After for #288:
image
Notice the video is not cut off by the player bar at the bottom, even on wider aspect ratios.

@9hax
Copy link
Author

9hax commented Jul 17, 2023

While this gets merged and eventually pulled into the marketplace, have the fixes in this as a Marketplace Snippet:

.VideoPlayer__container video,
.lyrics-lyricsContainer-LyricsContainer {
  padding-bottom: 105px;
}

@Lseoksee
Copy link
Contributor

I've checked the commit, but the annotation text and buttons look good now, but the center of the lyrics still seems a little low.

@250h
Copy link

250h commented Mar 8, 2024

I found that the video was just moved up, changing the occlusion from below to above. This is not a viable solution.

@9hax 9hax closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lyrics are too low in lyrics-plus
3 participants