Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues + request #220

Open
stpnwf opened this issue Mar 28, 2023 · 27 comments
Open

Issues + request #220

stpnwf opened this issue Mar 28, 2023 · 27 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@stpnwf
Copy link

stpnwf commented Mar 28, 2023

These issues can be reproduced on a brand new installation of Spotify + Spicetify + Marketplace with just Bloom installed from the Marketplace.
Still loving this Spotify theme. Thanks for it!

Issues:

1. Play and Pause buttons are overlayed onto themselves.
2. Some elements have the same color no matter the color scheme. Nothing in color.ini will affect them
3. Minor issue: there is no blur when clicking the user menu, unlike other dialogs
4. Play bar obstructs what Friends are playing as well as Lyrics
5. Weird glitch when scrolling through sidebar playlists

It scrolls fine until it gets about halfway through, then that happens...

Screencast.from.2023-03-28.19-46-33.webm
6. Liked Songs + Your Episode + New Play list buttons won't remain hidden once Spotify is restarted.
Screencast.from.2023-03-28.18-03-48.webm

Request

1. Any chance we could get support for custom images to be displayed instead of the folders? Ideally like Dribbblish, but anything similar really. Personally I am not a fan of how they look, and they even look broken on some dark color schemes... like Comfy and Dark Mono
@nimsandu
Copy link
Owner

nimsandu commented Apr 1, 2023

@stpnwf thanks for reaching out and providing a well-organized issue. we will do our best to resolve these issues in the near future

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented Apr 6, 2023

Play and Pause buttons are overlayed onto themselves
Minor issue: there is no blur when clicking the user menu, unlike other dialogs
Liked Songs + Your Episode + New Play list buttons won't remain hidden once Spotify is restarted.

Can't reproduce

@SunsetTechuila SunsetTechuila mentioned this issue Apr 6, 2023
@stpnwf
Copy link
Author

stpnwf commented Apr 7, 2023

Can't reproduce

I am on Linux, maybe that is it. Tried it on both Fedora 37 and Vanilla OS with Bloom from the marketplace and Spotify installed via Flathub.

Although some of those issues may not be relevant anymore given Spotify's redesign. Unsure if it will influence Bloom's interface going forward.

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented Apr 7, 2023

6 is definitely a spicetify issue, not a theme

@Raiden0456
Copy link

Can't reproduce

I am on Linux, maybe that is it. Tried it on both Fedora 37 and Vanilla OS with Bloom from the marketplace and Spotify installed via Flathub.

Although some of those issues may not be relevant anymore given Spotify's redesign. Unsure if it will influence Bloom's interface going forward.

Same here, pause and play buttons overlay each other, this is definitely a linux problem, as i'm running fedora 38 + GNOME

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented May 13, 2023

  1. Play bar obstructs what Friends are playing

Friends have been fixed in be77059

as well as Lyrics

feature, not a bug

@SunsetTechuila
Copy link
Contributor

  1. Weird glitch when scrolling through sidebar playlists

Fixed in a4ef0b5

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented May 13, 2023

  1. Some elements have the same color no matter the color scheme. Nothing in color.ini will affect them

and more can't be themed:
image

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented May 13, 2023

  1. Some elements have the same color no matter the color scheme. Nothing in color.ini will affect them

fixed completely in eb7b91a

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented May 19, 2023

Any chance we could get support for custom images to be displayed instead of the folders? Ideally like Dribbblish

added in a3b751b

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented May 19, 2023

Minor issue: there is no blur when clicking the user menu, unlike other dialogs

Can't reproduce

Now I know the reason. As karimawii has in #259 you probably have a menu appears right after the user-widget box element, not at the very end of the body - the result is that all content behind the menu actually is after it in DOM.
No content that is a DOM ancestor of the Backdrop Root element should contribute to or affect the Backdrop Root Image.

For the same reason, for example, this menu does not have blurred backdrop:
image
And this is what happens if we move it to the end of the body:
image

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented May 19, 2023

fixed
image

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented May 19, 2023

@stpnwf are we ready to close the issue?

nice green color scheme you have btw, do you want to make pr with it?

@stpnwf
Copy link
Author

stpnwf commented May 19, 2023

Thank you for fixing it! I won't be able to check it until hopefully this weekend, but I will close this issue and open another if there are still issues.
Do you have any idea when the updated version will hit Marketplace?

nice green color scheme you have btw, do you want to make pr with it?

Thanks, it is heavily inspired by the Zorin OS Dark Green color scheme. I really love it.
If you'd like I can make a PR, but I have never made one before, so I'd have to look up how to do it. LMK
These are the colors though:

text=BBF1DD
subtext=6b8a7f
alt-text=6b8a7f
main=1B2421
sidebar=1B2421
player=101411
player-border=33433d
player-bar-shadow=BBF1DD
player-bar-bg=323336
card=101411
shadow=101411
selected-row=33433D
button=28c48b
button-active=00ac6f
button-disabled=33433D
tab-active=33433D
notification=6b8a7f
notification-error=d43353
misc=6b8a7f
not-selected=6b8a7f
accent=BBF1DD
layer-shadow=1B2421
contour=1B2421

Sadly, I don't have a screenshot for it ATM bc I am playing around with a frankeinstein theme rn (in the pic below), but the pic below should have the same feel as the above color scheme.

Screenshot from 2023-05-19 19-07-29-obfuscated

@stpnwf stpnwf closed this as completed May 19, 2023
@SunsetTechuila
Copy link
Contributor

Do you have any idea when the updated version will hit Marketplace?

Usually it takes two days

If you'd like

Personally I definitely would

@SunsetTechuila
Copy link
Contributor

but I will close this issue and open another if there are still issues.

It's better not to close current issue until you are sure that all is fixed than to close and open a new one

@stpnwf
Copy link
Author

stpnwf commented May 19, 2023

Usually it takes two days

Awesome, then I will check that and file the request on Sunday.

It's better not to close current issue until you are sure that all is fixed than to close and open a new one

Alright, thanks for reopening it.

@SunsetTechuila SunsetTechuila added bug Something isn't working enhancement New feature or request labels May 21, 2023
@SunsetTechuila
Copy link
Contributor

Awesome, then I will check that and file the request on Sunday.

@stpnwf hello, just a quick reminder

@stpnwf
Copy link
Author

stpnwf commented Jun 1, 2023

@stpnwf hello, just a quick reminder

Sorry, I forgot.

Most issues were fixed but I still encountered some:

Screenshot from 2023-06-01 15-54-46

Screenshot from 2023-06-01 15-49-57

Screenshot from 2023-06-01 14-07-25

@SunsetTechuila
Copy link
Contributor

Most issues were fixed but I still encountered some:

I'm waiting for the color scheme first of all)

pic 1

white color was hardcoded by me because of visibility

pic 2

will be fixed

pic 3

what's wrong?

@SunsetTechuila
Copy link
Contributor

Thanks. I'll probably make all the buttons spice-text color

@stpnwf
Copy link
Author

stpnwf commented Jun 2, 2023

I'm waiting for the color scheme first of all)

I am having issues with SSH, will try pushing it once I get it working.

@stpnwf
Copy link
Author

stpnwf commented Jun 2, 2023

I'm waiting for the color scheme first of all)

Here you go!

@kernelb00t
Copy link

@stpnwf Are there still any issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants
@Raiden0456 @nimsandu @kernelb00t @stpnwf @SunsetTechuila and others