Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome flow not opening after account creation on Firefox #36

Open
sisou opened this issue Oct 21, 2020 · 3 comments
Open

Welcome flow not opening after account creation on Firefox #36

sisou opened this issue Oct 21, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@sisou
Copy link
Member

sisou commented Oct 21, 2020

In Firefox, the welcome screens that lead to the Login File are not appearing after creating a new account.

@sisou sisou added the bug Something isn't working label Oct 21, 2020
@mariofriz
Copy link
Contributor

@sisou Is this still required with the changes that force the download of login file during account creation?

@sisou
Copy link
Member Author

sisou commented Feb 20, 2021

Hi Mario,
you are right, it's not required anymore, but I still haven't checked yet if the welcome flow opens correctly on Firefox.

@sisou
Copy link
Member Author

sisou commented May 6, 2021

I just looked into this again. The welcome flow opens in Firefox during dev, but not in production. Experimenting with production builds, it seems the document.referrer is empty when coming back from the Hub (I have not found an explanation for why yet). This prevents the RpcClient from handling the redirect-response (it cannot validate a response's validity without a referrer and bails), which in turn leads to the welcome modal not getting triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants