Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser light client cannot maintain connections #2404

Closed
sisou opened this issue Apr 26, 2024 · 2 comments · Fixed by #2407
Closed

Browser light client cannot maintain connections #2404

sisou opened this issue Apr 26, 2024 · 2 comments · Fixed by #2407
Assignees
Labels
bug Something isn't working WASM

Comments

@sisou
Copy link
Member

sisou commented Apr 26, 2024

General information

  • Library version(s): v0.21.0
  • Browser version(s): Chrome 123.0.6312.122
  • Devices/Simulators/Machine affected: Desktop Linux
  • Reproducible in the testnet? (Yes/No): yes
  • Related issues: #

Bug report

Expected behavior

Browser light clients can establish and hold connections with peers.

Actual behavior

Browser clients panic when connecting to the first peer (seed) with:

thread '<unnamed>' panicked at 'there is no reactor running, must be called from the context of a Tokio 1.x runtime': /core-rs-albatross/network-interface/src/request/mod.rs:223

and can then no longer maintain connections, as peers disconnect after a few seconds because of response timeouts on their side.

Steps to reproduce

Either

or

  • Compile the browser client locally (./web-client/scripts/build.sh --only web --skip-types --skip-wasm-opt) and serve the web-client folder, then go to http://localhost/example. If seed1 is not up, change the seed node in web-client/example/module.js to a node that is up.
@sisou sisou added the bug Something isn't working label Apr 26, 2024
@sisou sisou self-assigned this Apr 26, 2024
@sisou
Copy link
Member Author

sisou commented Apr 26, 2024

It's caused by e7a0319.

@sisou sisou assigned styppo and unassigned sisou Apr 26, 2024
@sisou sisou added the WASM label Apr 26, 2024
@sisou
Copy link
Member Author

sisou commented Apr 26, 2024

I have tested that the code path in question that panics in WASM was not called at all in browser clients before that commit mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WASM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants