Remove unnecessary tokio::spawn #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viquezclaudio
force-pushed
the
viquezcl/remove_spawn
branch
from
97fb04d
to
d96032f
Compare
sisou
reviewed
Apr 26, 2024
sisou
approved these changes
Apr 26, 2024
paberr
approved these changes
Apr 27, 2024
hrxi
reviewed
Apr 29, 2024
There was a problem hiding this comment.
This
tokio::spawnseems unnecessary or superfluous (at least) according to the logic around it.
It doesn't seem entirely superfluous, it makes sure that each request cannot block the rest of the requests. If that's still wanted, then this change is incorrect.
jsdanielh
force-pushed
the
viquezcl/remove_spawn
branch
2 times, most recently
from
8fe2a69
to
220d10b
Compare
- Unnecessary tokio spawn - This is not compatible with web clients (WASM)
jsdanielh
force-pushed
the
viquezcl/remove_spawn
branch
from
220d10b
to
41a666c
Compare
We will address this in a separate issue (#2434). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could explain the failure mentioned in #2404
Before this change regular nodes didn't try to connect to web clients, because they were filtered: web clients do not provide any service to regular nodes. This can be observed in this code.
This means that before, web clients were not responding to any of the consensus handlers.
However, after the handle incompatible peers commit, regular nodes can now perform head requests to web clients, which causes web clients to execute a
tokio::spawn, which is not allowed (a special task executor is necessary in web environments).This
tokio::spawnseems unnecessary or superfluous (at least) according to the logic around it.This fixes #2404 .
Pull request checklist
clippyandrustfmtwarnings.