Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Validator change in pre-staking window not detected #2399

Closed
sisou opened this issue Apr 25, 2024 · 1 comment · Fixed by #2403
Closed

Migration: Validator change in pre-staking window not detected #2399

sisou opened this issue Apr 25, 2024 · 1 comment · Fixed by #2403
Assignees
Labels
bug Something isn't working

Comments

@sisou
Copy link
Member

sisou commented Apr 25, 2024

This address https://test.nimiq.watch/#NQ95+FHVN+JAN4+8LKT+LCE2+LC3T+P861+NK5M+HVGS delegated 2.8 million NIM to NQ65 ... H17C in block 3027744. Then it sent a 1 NIM transaction 3 minutes later in block 3027747 with data to delegate to NQ26 ... XVNY. That should have changed the delegation to the later validator.

However, in the genesis file this staker is delegating to NQ65 ... H17C, which I think is incorrect.

@sisou sisou added the bug Something isn't working label Apr 25, 2024
@jsdanielh
Copy link
Contributor

Issue seems to be that we are doing the minimum stake check for every transaction individually and not for the sum of all of the transactions that come from the sender and that also meet the pre-staking requirements

jsdanielh added a commit that referenced this issue Apr 25, 2024
Fix the detection of switching validator in pre-stake as it was
filtering always transactions that didn't have the minimum stake but
for switching to another validator in pre-stake, the stake is already
above the minimum since it was already counted to another validator.

This fixes #2399.
jsdanielh added a commit that referenced this issue May 2, 2024
Fix the detection of switching validator in pre-stake as it was
filtering always transactions that didn't have the minimum stake but
for switching to another validator in pre-stake, the stake is already
above the minimum since it was already counted to another validator.

This fixes #2399.
jsdanielh added a commit that referenced this issue May 8, 2024
Fix the detection of switching validator in pre-stake as it was
filtering always transactions that didn't have the minimum stake but
for switching to another validator in pre-stake, the stake is already
above the minimum since it was already counted to another validator.

This fixes #2399.
jsdanielh added a commit that referenced this issue May 10, 2024
Fix the detection of switching validator in pre-stake as it was
filtering always transactions that didn't have the minimum stake but
for switching to another validator in pre-stake, the stake is already
above the minimum since it was already counted to another validator.

This fixes #2399.
jsdanielh added a commit that referenced this issue May 16, 2024
Fix the detection of switching validator in pre-stake as it was
filtering always transactions that didn't have the minimum stake but
for switching to another validator in pre-stake, the stake is already
above the minimum since it was already counted to another validator.

This fixes #2399.
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants