Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate PoW to PoS history proactively #2409

Merged
merged 1 commit into from May 2, 2024
Merged

Migrate PoW to PoS history proactively #2409

merged 1 commit into from May 2, 2024

Conversation

Eligioo
Copy link
Member

@Eligioo Eligioo commented Apr 29, 2024 •
edited

What's in this pull request?

This PR adds the functionality for the nimiq-pow-migration client to start the PoW to PoS migration before the pre-stake window is closed. Additionally it is responsible for continuing to migrate the PoW history if instructed when for example a new activation window is started.

This fixes #2355

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@Eligioo Eligioo force-pushed the stefan/proactive-history-migration branch 2 times, most recently from 64ac61f to be5155b Compare April 30, 2024 11:12
hrxi
hrxi reviewed May 1, 2024
View reviewed changes
pow-migration/src/main.rs Outdated Show resolved Hide resolved
@Eligioo Eligioo force-pushed the stefan/proactive-history-migration branch from be5155b to 63f6503 Compare May 1, 2024 14:54
jsdanielh
jsdanielh reviewed May 2, 2024
View reviewed changes
pow-migration/src/history/mod.rs Outdated Show resolved Hide resolved
pow-migration/src/history/mod.rs Outdated Show resolved Hide resolved
pow-migration/src/main.rs Outdated Show resolved Hide resolved
pow-migration/src/main.rs Outdated Show resolved Hide resolved
pow-migration/src/main.rs Outdated Show resolved Hide resolved
pow-migration/src/main.rs Outdated Show resolved Hide resolved
@Eligioo Eligioo force-pushed the stefan/proactive-history-migration branch from 63f6503 to d818b04 Compare May 2, 2024 11:44
@Eligioo
Copy link
Member Author

Eligioo commented May 2, 2024

Rebasing

@Eligioo Eligioo force-pushed the stefan/proactive-history-migration branch from d818b04 to 3ca28dc Compare May 2, 2024 11:47
@Eligioo
Copy link
Member Author

Eligioo commented May 2, 2024 •
edited

@jsdanielh all changes have been resolved

jsdanielh
jsdanielh approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsdanielh
Copy link
Contributor

Rebasing it to merge it

@jsdanielh jsdanielh force-pushed the stefan/proactive-history-migration branch from 3ca28dc to 5ddacfe Compare May 2, 2024 16:53
@jsdanielh jsdanielh merged commit 5ddacfe into albatross May 2, 2024
6 checks passed
@jsdanielh jsdanielh deleted the stefan/proactive-history-migration branch May 2, 2024 17:26
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrxi hrxi hrxi left review comments

@jsdanielh jsdanielh jsdanielh approved these changes

@viquezclaudio viquezclaudio Awaiting requested review from viquezclaudio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nimiq PoS Mainnet
Development

Successfully merging this pull request may close these issues.

Migration: Migrate existing history proactively
3 participants
@Eligioo @jsdanielh @hrxi