Feature request - expose an interface to retrieve all affected addresses from a transaction

[redmaner]

Current transactions returned over RPC include the from and to fields but these fields do not always cover all affected addresses in the transaction.

For example:

• given pool X
• having delegated staker A
• pool X adds stake to staker A
• the transaction from field is set to pool X and the recipient is set to the staking contract. The address of staker A has to be parsed from recipientData

This issue requests either of two things:

• include the staker_address in the transaction, so we always know which staker is affected by a staking contract transaction and / or
• expose an RPC method to retrieve the affected addresses for a transaction. Apparently a transaction struct already has a function to retrieve affected addresses which may be something that can be exposed over RPC so other languages don't have to manually parse convoluted fields to retrieve the required information.

[sisou]

Hmm... seems I was mistaken when I said there is already an internal mechanism to get affected addresses for a transaction. The history store in fact only indexes by sender and recipient :(

core-rs-albatross/blockchain/src/history/history_store.rs

Lines 955 to 976 in fe7c294

	let index_tx_sender = self.get_last_tx_index_for_address(&tx.sender, Some(txn)) + 1;
	txn.put(
	&self.address_table,
	&tx.sender,
	&OrderedHash {
	index: index_tx_sender,
	hash: raw_tx_hash.clone().into(),
	},
	);
	let index_tx_recipient =
	self.get_last_tx_index_for_address(&tx.recipient, Some(txn)) + 1;
	txn.put(
	&self.address_table,
	&tx.recipient,
	&OrderedHash {
	index: index_tx_recipient,
	hash: raw_tx_hash.into(),
	},
	);

Probably what I remember was just an idea, instead of implemented.

[sisou]

Here is what I remembered: the Log struct has this method!

core-rs-albatross/primitives/account/src/logs.rs

Line 222 in 89a8b67

pub fn is_related_to_address(&self, address: &Address) -> bool {

[paberr]

It will be difficult to make this accessible from the transaction itself.
However, that's what the Log mechanism was designed for: to get more meaningful "events" related to specific addresses.

@redmaner: Does the Log mechanism solve your problem?

[redmaner]

Why is this difficult to make accessible from the transaction itself while the data is encoded in recipient_data and sender_data just in an non human readable format? Having RPC calls to decode that into JSON would already be helpful