Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fix for Chrome, Brave & Firefox #5

Open
nileshtrivedi opened this issue Aug 2, 2020 · 3 comments · Fixed by #18
Open

Test and fix for Chrome, Brave & Firefox #5

nileshtrivedi opened this issue Aug 2, 2020 · 3 comments · Fixed by #18
Assignees
@anirudhvarma12

Comments

@nileshtrivedi
Copy link
Owner

No description provided.

@anirudhvarma12
Copy link
Collaborator

I will pick this up, was trying to port to firefox and getting a manifest related error.

The storage API will not work with a temporary addon ID. Please add an explicit addon ID to your manifest.

@anirudhvarma12 anirudhvarma12 mentioned this issue Aug 8, 2020
Merged
@nileshtrivedi
Copy link
Owner Author

Firefox Store reports these warnings while publishing the extension:

image

@nileshtrivedi nileshtrivedi reopened this Aug 10, 2020
@nileshtrivedi
Copy link
Owner Author

After merging #19 that attempts to fix #3 , I get this:

image

@nileshtrivedi nileshtrivedi mentioned this issue Aug 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anirudhvarma12 anirudhvarma12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add extension id to make storage API work on Firefox in dev. nileshtrivedi/better
2 participants
@nileshtrivedi @anirudhvarma12