-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX failing load_confound
test related to standardisation
#4411
Conversation
👋 @htwangtw Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4411 +/- ##
==========================================
+ Coverage 91.85% 92.03% +0.17%
==========================================
Files 144 143 -1
Lines 16419 16639 +220
Branches 3434 3529 +95
==========================================
+ Hits 15082 15313 +231
+ Misses 792 758 -34
- Partials 545 568 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a871535
to
3aa1cdd
Compare
load_confound
test related to standardisation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM. Thx.
LGTM too! Thanks! |
Follow up PR: update CI to not test on macOS 13 and 14 separately |
Changes proposed in this pull request:
load_confound
testNotes:
detrend=True
and the value is extremely close to zero in those instances hence we came up with this idea.