Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX failing load_confound test related to standardisation #4411

Merged
merged 3 commits into from
May 15, 2024

Conversation

htwangtw
Copy link
Member

@htwangtw htwangtw commented May 7, 2024

Changes proposed in this pull request:

  • add trend to the simulated signal in load_confound test

Notes:

  • the tests were only failing when detrend=True and the value is extremely close to zero in those instances hence we came up with this idea.

Copy link
Contributor

github-actions bot commented May 7, 2024

👋 @htwangtw Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (abb80ff) to head (82a684d).
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4411      +/-   ##
==========================================
+ Coverage   91.85%   92.03%   +0.17%     
==========================================
  Files         144      143       -1     
  Lines       16419    16639     +220     
  Branches     3434     3529      +95     
==========================================
+ Hits        15082    15313     +231     
+ Misses        792      758      -34     
- Partials      545      568      +23     
Flag Coverage Δ
macos-13_3.11_test_plotting 91.81% <100.00%> (?)
macos-latest_3.11_test_plotting ?
ubuntu-latest_3.10_test_plotting 91.81% <100.00%> (-0.05%) ⬇️
ubuntu-latest_3.11_test_plotting 91.81% <100.00%> (?)
ubuntu-latest_3.12_test_plotting 91.81% <100.00%> (?)
ubuntu-latest_3.12_test_pre 91.81% <100.00%> (?)
ubuntu-latest_3.8_test_min 68.72% <100.00%> (?)
ubuntu-latest_3.8_test_plot_min 91.48% <100.00%> (?)
ubuntu-latest_3.8_test_plotting 91.77% <100.00%> (?)
ubuntu-latest_3.9_test_plotting 91.78% <100.00%> (?)
windows-latest_3.10_test_plotting 91.79% <100.00%> (?)
windows-latest_3.11_test_plotting 91.79% <100.00%> (?)
windows-latest_3.12_test_plotting 91.79% <100.00%> (?)
windows-latest_3.8_test_plotting 91.75% <100.00%> (?)
windows-latest_3.9_test_plotting 91.75% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@htwangtw htwangtw changed the title FIX source of numerical instibility FIX failing load_confound test related to standardisation May 8, 2024
@htwangtw htwangtw marked this pull request as ready for review May 8, 2024 16:30
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. Thx.

@htwangtw htwangtw requested review from Remi-Gau and man-shu May 14, 2024 13:34
@man-shu
Copy link
Contributor

man-shu commented May 15, 2024

LGTM too! Thanks!

@man-shu man-shu merged commit 9745e42 into nilearn:main May 15, 2024
30 checks passed
@Remi-Gau
Copy link
Collaborator

Follow up PR: update CI to not test on macOS 13 and 14 separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures of some tests for load_confounds on mac OS 14
4 participants