-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Fix typos found by codespell #4410
Conversation
DimitriPapadopoulos
commented
May 6, 2024
- A couple typos.
👋 @DimitriPapadopoulos Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4410 +/- ##
==========================================
+ Coverage 91.85% 92.02% +0.17%
==========================================
Files 144 143 -1
Lines 16419 16635 +216
Branches 3434 3528 +94
==========================================
+ Hits 15082 15309 +227
+ Misses 792 758 -34
- Partials 545 568 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DimitriPapadopoulos !
sweet!!! now I need to figure out why our codespell set up missed those! |
These typos mush have been added to codespell recently - and haven't made it to the release you're running. |
OK no idea how you detected those changes but does not matter. will add one commit to tweak the codespell config to ignore some temp files that may get generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reordered this one
we are using v2.2.6 🤷🏾 nilearn/.pre-commit-config.yaml Line 95 in 819cd24
|
Yes, but I am always using the |
ha ok makes more sense |