Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix typos found by codespell #4410

Merged
merged 2 commits into from
May 8, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

  • A couple typos.

Copy link
Contributor

github-actions bot commented May 6, 2024

👋 @DimitriPapadopoulos Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (abb80ff) to head (0117427).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4410      +/-   ##
==========================================
+ Coverage   91.85%   92.02%   +0.17%     
==========================================
  Files         144      143       -1     
  Lines       16419    16635     +216     
  Branches     3434     3528      +94     
==========================================
+ Hits        15082    15309     +227     
+ Misses        792      758      -34     
- Partials      545      568      +23     
Flag Coverage Δ
macos-latest_3.11_test_plotting ?
ubuntu-latest_3.10_test_plotting 91.81% <ø> (-0.05%) ⬇️
ubuntu-latest_3.11_test_plotting 91.81% <ø> (?)
ubuntu-latest_3.12_test_plotting 91.81% <ø> (?)
ubuntu-latest_3.12_test_pre 91.81% <ø> (?)
ubuntu-latest_3.8_test_min 68.71% <ø> (?)
ubuntu-latest_3.8_test_plot_min 91.47% <ø> (?)
ubuntu-latest_3.8_test_plotting 91.77% <ø> (?)
ubuntu-latest_3.9_test_plotting 91.77% <ø> (?)
windows-latest_3.10_test_plotting 91.78% <ø> (?)
windows-latest_3.11_test_plotting 91.78% <ø> (?)
windows-latest_3.12_test_plotting 91.78% <ø> (?)
windows-latest_3.8_test_plotting 91.74% <ø> (?)
windows-latest_3.9_test_plotting 91.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DimitriPapadopoulos !

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented May 8, 2024

sweet!!!

now I need to figure out why our codespell set up missed those!

@DimitriPapadopoulos
Copy link
Contributor Author

These typos mush have been added to codespell recently - and haven't made it to the release you're running.

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented May 8, 2024

OK no idea how you detected those changes but does not matter.

will add one commit to tweak the codespell config to ignore some temp files that may get generated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reordered this one

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented May 8, 2024

These typos mush have been added to codespell recently - and haven't made it to the release you're running.

we are using v2.2.6 🤷🏾

rev: v2.2.6

@DimitriPapadopoulos
Copy link
Contributor Author

Yes, but I am always using the master branch locally, ahead of releases.

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented May 8, 2024

Yes, but I am always using the master branch locally, ahead of releases.

ha ok makes more sense

@Remi-Gau Remi-Gau merged commit 7a68dab into nilearn:main May 8, 2024
29 of 30 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch May 8, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants