-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize "nilearn" atlases #4329
Comments
Note that the list of labels should also include "background" (or "Background") |
Even though working on this should fix #4330 and #4331, it will change what it returned by some of the fetchers (some even if not an API change, it would be a behavior change that should probably go through a deprecation cycle - not 100% about this). For example, the Destrieux fetcher would return 'labels' as list of strings and not a numpy.recarray containing the names of the ROIs. So this feels like a bit of an "invasive" change to include into 0.10.4 that should be a bug fix release. So I suggest making that change after 0.10.4 is out. |
Was checking on the templateFlow atlases and not all of them explicitly includes "background" in their list of labels so I would not make this required for Nilearn list of labels (for example by throwing an error if a user passed a list of labels to NiftiLabelMasker that did not include "background"). |
Indeed, we need to go through deprecation cycles for that one. |
IIUC, going through the deprecation cycle would involve warning users about the changes for a few releases before actually inteoducing them? |
Will close this in favor of @4335 (that is more detailed). Will move people's comments over there. |
(for example that each fetcher returns a list of labels as a list of strings)
and throw errors if they do not pass
instead of warnings like they do here.
Originally posted by @Remi-Gau in #4289 (comment)
The text was updated successfully, but these errors were encountered: