Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend/improve support for pathlib.Path #4327

Open
Remi-Gau opened this issue Mar 19, 2024 · 0 comments
Open

Extend/improve support for pathlib.Path #4327

Remi-Gau opened this issue Mar 19, 2024 · 0 comments
Labels
API This issue is related to the Nilearn's API. Code quality This issue tackles code quality (code refactoring, PEP8...). Effort: medium The issue is likely to require a decent amount of work (in between a few hours and a couple days). Impact: low Solving this issue will have a small impact on the project. Priority: low The task is not urgent and can be delayed.

Comments

@Remi-Gau
Copy link
Collaborator

On that note, it may be worth checking in the public API that users can also pass a Path in places where they can pass a string to a file.

I have not checked but it seems that many functions require a string and that Paths are not supported (or at least the doc string is not necessarily explicit - or I missed it).

May be done as some internal refactoring to rely more on pathlib rather than os (where relevant) - to be discussed.

Originally posted by @Remi-Gau in #4323 (comment)
@Remi-Gau Remi-Gau added API This issue is related to the Nilearn's API. Code quality This issue tackles code quality (code refactoring, PEP8...). Effort: medium The issue is likely to require a decent amount of work (in between a few hours and a couple days). Impact: low Solving this issue will have a small impact on the project. Priority: low The task is not urgent and can be delayed. labels Mar 19, 2024
@Remi-Gau Remi-Gau changed the title Extend/imporve support for pathlib.Path Extend/improve support for pathlib.Path Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API This issue is related to the Nilearn's API. Code quality This issue tackles code quality (code refactoring, PEP8...). Effort: medium The issue is likely to require a decent amount of work (in between a few hours and a couple days). Impact: low Solving this issue will have a small impact on the project. Priority: low The task is not urgent and can be delayed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Remi-Gau