New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add footer to all reports #4307
base: main
Are you sure you want to change the base?
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4307 +/- ##
==========================================
+ Coverage 91.85% 92.12% +0.27%
==========================================
Files 144 143 -1
Lines 16419 16438 +19
Branches 3434 3444 +10
==========================================
+ Hits 15082 15144 +62
+ Misses 792 749 -43
Partials 545 545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For reviewBefore (current dev doc)
After |
I like the change. |
Given that this is not a bug fix (next release should be mostly bug fixes) I think we can take the time to think about it and possibly find a way to not display them in notebooks. |
probably worth refactoring the CSS across reports first
|
Changes proposed in this pull request: