Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract is_plotly_installed function #3974

Closed
Remi-Gau opened this issue Sep 13, 2023 · 0 comments · Fixed by #4034
Closed

extract is_plotly_installed function #3974

Remi-Gau opened this issue Sep 13, 2023 · 0 comments · Fixed by #4034
Assignees
@Remi-Gau
Labels
Code quality This issue tackles code quality (code refactoring, PEP8...). Effort: low The issue is likely to require a small amount of work (less than a few hours). Impact: low Solving this issue will have a small impact on the project. Priority: low The task is not urgent and can be delayed.
Milestone
release 0.10.3

Comments

@Remi-Gau
Copy link
Collaborator

Wonder if some of this should not be extracted into a separate utility function is_plotly_installed().

this should probably be done in a different PR though, so don't overthing it for this PR

Originally posted by @Remi-Gau in #3949 (comment)
@Remi-Gau Remi-Gau added the Code quality This issue tackles code quality (code refactoring, PEP8...). label Sep 19, 2023
@Remi-Gau Remi-Gau added Impact: low Solving this issue will have a small impact on the project. Effort: low The issue is likely to require a small amount of work (less than a few hours). Priority: low The task is not urgent and can be delayed. labels Sep 29, 2023
@Remi-Gau Remi-Gau added this to the release 0.11.0 milestone Oct 4, 2023
@Remi-Gau Remi-Gau self-assigned this Oct 7, 2023
@Remi-Gau Remi-Gau mentioned this issue Oct 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Remi-Gau Remi-Gau

Labels
Code quality This issue tackles code quality (code refactoring, PEP8...). Effort: low The issue is likely to require a small amount of work (less than a few hours). Impact: low Solving this issue will have a small impact on the project. Priority: low The task is not urgent and can be delayed.
Projects
None yet
Milestone
release 0.10.3
Development

Successfully merging a pull request may close this issue.

[MAINT] refactor is plotly installed Remi-Gau/nilearn
1 participant
@Remi-Gau