Meta: rc branch status / repo cleanup

[usmonster]

Hi @niklasvh. Thanks for a great tool! It's really freaking awesome.

I just wanted to know if there's anything we can do to help make the rc branch pass all the build tests, maybe turn the rc branch into the new develop branch (or at least merge it), triage (categorize, close/merge, assign to milestones) all the issues, and get a new version out?

Looks like the last commit was a couple months ago, though it also looks like a bunch of issues have been addressed on the rc branch, even though the build fails. Meanwhile, lots of (possibly-irrelevant) issues against the year-old version continue to be filed.

Do you need collaborators? Or can you make a "helpwanted" label to highlight particular issues that break the build on the rc branch? I know it's not your full-time job, but--whenever you have a chance--feel free to use the crowd to help get everything in ship shape.

Thanks again, and keep up the amazing work!

[niklasvh]

As you mentioned it has been a few months since I last worked on it, so I can't recall from the top of my head all the unresolved issues with the rc branch, but the few major ones as I recall were:

• Gradient support
• Async parsing
• Tests working (can't recall whether this was just because gradients weren't implemented or was there something else still broken)
• Canvas rendering (Flot graphs not rendered in 0.5, was working with 0.4.1 #433)
• Unicode rendering (arabic font was not supported #405, Hindi characters are not rendered properly #330, arabic and persian not rendering correctly when text-align is set to centered #289, Improve for thai langauge #273, Unicode font problem #226, Font Problem  #440, Font rendered differently #422 etc.)
• Add code style linting to jshint (code cleanup / linting #370)
• Update documentation (Full Documentation #468)
• Border radius content clipping (html2canvas border radius not applying to img tag #399, Image with border-radius does't work #346)
• Render checkbox/radios (Updated version of support for checkboxes and radio buttons #406, Added support for Checkboxes and radio boxes #159, Input box text and checkbox/radio issue #425, Input Buttons wont display #418)

I'll try and have a closer look at what else might still be missing/broken and make a list of things that need to be done before it can be merged to master.

[usmonster]

Thanks!

[niklasvh]

I've merged it to master (to avoid more bug fixes and pull requests on the old version), but the above mentioned issues still remain to be fixed.

[usmonster]

That's progress, anyway--thanks!

I guess next step might be ensuring that all test failures are real (i.e. due to missing or broken functionality, not due to broken tests).

Once that's done, or maybe even sooner, bug triage could be easily crowdsourced (e.g., on each issue that seems like a valid bug you can ping the author to see if their problem is still present on master, and maybe also add a "please retest" label to get more attention).

Getting help implementing gradient support might just be a matter of adding an issue for it with a "help wanted" label or similar and a description of current progress and snags.

Thanks again for being so responsive!

[niklasvh]

Tests are working now (as in running), so anything failing now is a missing feature.
SVG image taint testing seems to be an issue at least for IE.

[usmonster]

Nice! Thanks for all your work on this.

[usmonster]

Tiny other things:

• It looks like the rc branch is no longer needed, so you might want to delete it so people don't mistakenly try to use that (unless you have other reasons to keep it around)
• The develop branch also seems redundant now (though it's referenced in the Contributing section of the README).
• The v0.4 branch looks like it had a few commits that never made it into master ..was this on purpose? Looks like the branch is quite different from the 0.4.0 tag on master anyway.. Just wanted to make sure no commits are missing from master or were accidentally merged into the wrong branch.

[usmonster]

Great progress so far, @niklasvh. Any word on the issues mentioned in my previous comment? Notably, the commits missing from master: https://github.com/niklasvh/html2canvas/compare/v0.4 ... Thanks yet again!

[niklasvh]

The border-radius commit broke existing border-radius tests, so it was omitted for that reason. For the IE9 issue, the suggested fix had nothing to do with the root problem, which was using incorrect positions for cropping.

The contributing readme should get updated. I deleted the old branches.

[niklasvh]

Added first prerelease (0.5.0-alpha1) to

• https://github.com/niklasvh/html2canvas/releases/tag/0.5.0-alpha1
• https://www.npmjs.com/package/html2canvas

[niklasvh]

Closing, #1167