Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gedcom::Individual::relationship: Add step-relationships #97

Open
tukusejssirs opened this issue Oct 17, 2019 · 2 comments
Open

Gedcom::Individual::relationship: Add step-relationships #97

tukusejssirs opened this issue Oct 17, 2019 · 2 comments
Assignees

Comments

@tukusejssirs
Copy link

In Gedcom::Individual::relationship, you missed step-brother and step-sister. Difference between half-sibling and step-sibling is that half-siblings have one common parent, where step-siblings none.

I could create a PR with the following code added:

if(($self->mother() ne $other->mother()) && ($self->father() ne $other->father())) {
  return ($sex eq 'M') ? 'step-brother' : 'step-sister';
}

but when is the following code used?

return $self->relationship_down($other) || $self->relationship_up($other);

@nigelhorne
Copy link
Owner

This can only be done if step-mother and/or step-father relationships are worked out. Which currently they are not.

@tukusejssirs
Copy link
Author

I’ll look at it out tomorrow (CEST).

@tukusejssirs tukusejssirs changed the title Gedcom::Individual::relationship: Add step-sibling relationship Gedcom::Individual::relationship: Add step-relationships Oct 19, 2019
@nigelhorne nigelhorne self-assigned this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants