Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting 2020-03-26 #34

Open
MatanBorenkraoutNielsen opened this issue Mar 26, 2020 · 0 comments
Open

Meeting 2020-03-26 #34

MatanBorenkraoutNielsen opened this issue Mar 26, 2020 · 0 comments

Comments

@MatanBorenkraoutNielsen
Copy link
Contributor

These are the issues we raised during this meeting:

  • Think about adding backend orientation to the style guide
  • Talk about BDD in the basic rules (how we write assertions)
  • Opinion about snapshots
  • Talk about TDD or just mention it
  • Visual testing
  • What do we say about coverage
  • Should we talk about linters?
  • We're talking very shortly about E2E
  • Act in React and async side effects shouldn't be in the basic rules imo
  • Should we test selectors, reducers?
  • The E2E diagram should be revisited for UX manners.
  • There's missing information about E2E, why we do it and how
  • In the bad examples - Add comments inside the code
  • What are our thoughts about getByText? (Translation related)

Participants:
@lidoravitan @einatnielsen @liadShiranNielsen @MatanBorenkraoutNielsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant