Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do & Don't sections mixed up in Redux Connected Component example? #31

Open
egidijusj opened this issue Feb 14, 2020 · 1 comment
Open

Do & Don't sections mixed up in Redux Connected Component example? #31

egidijusj opened this issue Feb 14, 2020 · 1 comment
Labels
bug enhancement

Comments

@egidijusj
Copy link

Is it me, or Do and Don't sections are mixed up in here? https://github.com/nielsen-oss/docs/tree/master/javascript/testing#redux-connected-component

Currently it says one should mock action creators instead of verifying result in DOM.
@einatnielsen
Copy link
Contributor

einatnielsen commented Feb 16, 2020 •
edited by liadShiranNielsen

Hi @egidijusj thank you for opening this issue!
Feel free to open PR for this issue.
Please let us know if you want to take it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@egidijusj @lidoravitan @einatnielsen