Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sublime-gulp should respect "folder_exclude_patterns" and "file_exclude_patterns" #79

Open
Ivanca opened this issue Jan 30, 2017 · 3 comments

Comments

@Ivanca
Copy link

Ivanca commented Jan 30, 2017

Right now when I execute the gulp command it asks me which of 2 gulpfile.js should I use, despite one of them being excluded from the project (at the project level, at .sublime-project) which makes no sense.

More info about "folder_exclude_patterns" and "file_exclude_patterns" see https://www.sublimetext.com/docs/3/projects.html

@nicosantangelo
Copy link
Owner

The problem with using folder_exclude_patterns and file_exclude_patterns is that if a user in the same situation won't be able to use that gulpfile even if it wants to. That's why (early on) I've added the ignored_gulpfile_folders setting.

That said, we could add a boolean setting to append folder_exclude_patterns and file_exclude_patterns to ignored_gulpfile_folders defaulting to false (to keep current behaviour and don't break existing workflows)

What do you think?

@Ivanca
Copy link
Author

Ivanca commented Jan 31, 2017

folder_exclude_patterns and file_exclude_patterns are established by the Sublime Text user; so basically you are asking what happens if the user establishes a configuration and later on the user himself regrets it? That makes little sense to me; anyway, one can always change those options to make the gulpfile appear again.

But arguably this is a problem with Sublime itself, it shouldn't even give plugins access to files outside the project.

Of course ignored_gulpfile_folders is better than nothing and I'm glad it exists.

@Ivanca
Copy link
Author

Ivanca commented Feb 7, 2017

Nope; I can't make "ignored_gulpfile_folders" to work, apparently doing "ignored_gulpfile_folders": ["app"] it's not enough to make it stop looking for gulpfiles inside folders called app.

Another reason to not implement your own options when possible.

Edit: Found the bug causing this, script was skipping root folders, PR at #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants