-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual artifacts upon first keypress #75
Comments
So far, i Have personally observed:
My phone is running /e/-OS, a LineageOS derivate, since Android flavours probably differ in their rendering and resume behaviour. @nicolasbrailo, do your "jumping" keys happen in the "closed from recent apps" scenario? |
Just a realisation, while I was refactoring Should we (re)draw on Current implementation: PianOli/app/src/main/java/com/nicobrailo/pianoli/PianoCanvas.java Lines 325 to 328 in 453e67d
|
@juleskers good find. I think it only makes sense to redraw when the OS is telling us the screen changed! |
In #73, @nicolasbrailo mentioned jumping keys upon first keypress.
While I haven't seen size changes myself, I have seen black areas that only get filled out after the first touch.
It seems we have some kind of cached screen surface (probably from Android itself?) that only gets repainted on first trigger.
Since I am not quite sure where to start fixing this, I'm opening this ticket to track the investigation.
The text was updated successfully, but these errors were encountered: