Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple ways to exit #52

Open
amitkot opened this issue Jan 22, 2023 · 4 comments
Open

Multiple ways to exit #52

amitkot opened this issue Jan 22, 2023 · 4 comments
Labels
question Further information is requested

Comments

@amitkot
Copy link

amitkot commented Jan 22, 2023

Thanks for this app!

Playing for a minute I found multiple ways to exit.
On my phone the navigation is enabled using screen-edge swipe gestures and the bottom bar.

  • Back using swipe gestures work
  • Swipe down from top show notifications and bottom bar, allowing click on notification and using bottom bar for "home" or app switching
@nicolasbrailo
Copy link
Owner

Hi @amitkot, thanks for reporting. There is no way in (regular) Android to have a (regular) app completely overtake your screen: all this does is say "hi Android OS, please pin me to the screen and don't let anyone close my window". If the OS has an alternate way of letting you close that window, there is nothing the app can do. This is dependent on the specific phone and OS version, and it's usually a good thing, as you don't want an app to hijack your phone completely.

Having said that, if you find an extra API we could use to disable any of the alternate un-pin behaviours, I'd be happy to accept a PR.

@cptechnik
Copy link

Others device, other problem:
Moto G51 5g : No way to exit!
Every time I push both buttons, my device is locked, after unlock, pianoli get focus and shows the two button info, also if I tip on notifications...
Then suddenly the notification bar appears, and with the settings wheel I get into "apps" and can deinstall pianoli...

@juleskers
Copy link
Collaborator

Others device, other problem

Then it shouldn't really belong in this thread, but have a separate issue.

As a note for future travelers, the way "out" of PianOli is to press the top-right "X" in the settings screen.

@juleskers
Copy link
Collaborator

juleskers commented Dec 25, 2023

On my phone the navigation is enabled using screen-edge swipe gestures and the bottom bar.

I've tried to reproduce this today, and could not exit the app in this way.

I run 'e/OS' (a.k.a. Murena), a LineageOS fork.
The launcher is a bit atypical. For Swipe Navigation however, I believe it's effectively Stock.

Steps taken:

  1. Switch device to swipe navigation: Settings > System > Gestures > System Navigation > set to "gesture navigation` (Not sure about the exact translations, I run Dutch language)
  2. Bottom bar switches from previous "three buttons (back, home, app overview)" to a thin, draggable bar.
    Dragging this bar up goes to home-screen; Dragging it up and hold-then-release goes to app overview.; Dragging from the left or right triggers "back"
    (I'm repeating my observed behaviour, just to avoid confusion with possible custom UI behaviour)
  3. Open PianOli, which launches into pinned piano
  4. Accept the "app is pinned" OS dialog ("I understand"/"Got it")
  5. Swipe from "left/right" (due to Piano rotation, this is now top/botton, i.e. the short edges of the screen)
    => OS plays "Back" arrow animation, but piano stays in place; after a second swipe-attempt, OS shows a toast "swipe up and hold to unpin app"
  6. Swipe-up without hold shows the bottom drag-bar and a semi-transparent, but empty, notification bar, but otherwise does nothing.
  7. swipe-up-and-hold opens my lock-screen (without playing Pianoli's distinct "escape warning bell", so it must be OS-behaviour)
  8. Unlocking my phone immediately returns me to PianOli, with a new "app is pinned" dialog. (so, back to step 3+4)
  9. if, this time, I refuse the "app is pinned" dialog (clicking the "no, thank you" button), I obtain the behaviour @amitkot describes: left/right swipe (short edges) triggers "back" (in this case, to OS home screen), bottom-bar drag opens app overview.

@amitkot : Can you confirm/refute that we are talking about the same thing?
If you still have the exit behaviour from above, it would be very interesting which Android Flavour you are running, to see if perhaps that has a "weird" behaviour for app-pinning.

P.S. Sorry for the lengthy delay since Januari, @amitkot. As a volunteer project, where all the maintainers have children themselves, "fast feedback" isn't exactly something we're known for 😝
I hope you're still interested in PianOli, and that it's still bringing joy to your child(ren).

@juleskers juleskers added the question Further information is requested label Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants