Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: ReactRouter v4 #45

Open
Lutando opened this issue Feb 4, 2017 · 8 comments
Open

PR: ReactRouter v4 #45

Lutando opened this issue Feb 4, 2017 · 8 comments

Comments

@Lutando
Copy link

Lutando commented Feb 4, 2017

Would a PR with an update for ReactRouter v4 be welcomed?

@nicksp
Copy link
Owner

nicksp commented Feb 10, 2017

Hi @Lutando It would be more than welcome.
I had some timing issues recently... but looking forward to getting back to the project asap. I've got some more knowledge with React and started using more tools on daily basis and gonna give a second life to the boilerplate.... So all PR welcome! :)

@nicksp nicksp closed this as completed Feb 10, 2017
@nicksp nicksp reopened this Feb 21, 2017
@nicksp
Copy link
Owner

nicksp commented Feb 21, 2017

Hey @Lutando Do you think you'll have a chance to submit a PR for that?

@Lutando
Copy link
Author

Lutando commented Feb 21, 2017

Hi @nicksp I will definitely do that on Saturday how does that sound? :)

@Lutando
Copy link
Author

Lutando commented Feb 21, 2017

Also would you like it done in the old style (routes defined in a routes.js folder as it is now) or the new composable style as per their docs. I guess either way is a matter of preference. I am tend to lean towards the latter option.

@nicksp
Copy link
Owner

nicksp commented Feb 22, 2017

That's great @Lutando, whenever you have a time. For sure i'd expect latest recommended composable style :)

@Lutando
Copy link
Author

Lutando commented Feb 27, 2017

Almost done with it just need to cleanup some things, expect a PR in the next few days

@nicksp
Copy link
Owner

nicksp commented Feb 28, 2017

@Lutando Cool, really excited about that ;)

@circlingthesun
Copy link

This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants