Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add support for eslint-plugin-compat #43

Open
amilajack opened this issue Jan 2, 2017 · 5 comments
Open

PR: Add support for eslint-plugin-compat #43

amilajack opened this issue Jan 2, 2017 · 5 comments

Comments

@amilajack
Copy link
Contributor

amilajack commented Jan 2, 2017

This eslint plugin lints against APIs that are only supported by target browsers 馃帀 Would a PR for this be welcome?

Here's a demo of it in action

demo of plugin usage

@nicksp
Copy link
Owner

nicksp commented Feb 10, 2017

Hey @amilajack

Sorry for the delay in response. Been busy with projects....
Yeah it looks really nice and i'd like to have it as PR for my boilerplate, which i'm going to significantly update in several next days...

@nicksp nicksp closed this as completed Feb 10, 2017
@nicksp nicksp reopened this Feb 21, 2017
@nicksp
Copy link
Owner

nicksp commented Feb 21, 2017

@amilajack Do you think you'll have a chance to submit PR?

@amilajack
Copy link
Contributor Author

Sure thing!

@amilajack
Copy link
Contributor Author

Having trouble doing this because i'm not used to the kinds of configuration setup this project uses. I also cant seem to run the test correctly because they keep failing

@nicksp
Copy link
Owner

nicksp commented Feb 22, 2017

@amilajack You can skip tests for now, as i said in README they fail and am rewriting them atm to the setup i'm more used to. If you need help with anything else, just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants