Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review/improve sizehints #37

Open
nickrobinson251 opened this issue Oct 24, 2021 · 0 comments
Open

Review/improve sizehints #37

nickrobinson251 opened this issue Oct 24, 2021 · 0 comments
Labels
improvement improvement to an existing feature

Comments

@nickrobinson251
Copy link
Owner

nickrobinson251 commented Oct 24, 2021 •
edited

We switched how we populate the data, from counting and preallocating, to instead be using push! (#10).

I added some initial sizehint!s in #10 but i didn't spend much time on them, and they're surely biased to the source of data i have (#5 (comment)), so can likely be improved!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickrobinson251