Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reddit re-design compatibility? #2

Open
ghost opened this issue May 1, 2021 · 4 comments
Open

Reddit re-design compatibility? #2

ghost opened this issue May 1, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 1, 2021

Any plans to make Rededup Reddit's redesign compatible?

What are the major hurdles to make this new Reddit compatible?

@nickgaya
Copy link
Owner

nickgaya commented May 2, 2021

Hi @dareksartre, and thanks for your interest in Reddit Deduplicator! These are good questions. When I initially developed this add-on, I investigated adding support for "New Reddit" but decided not to do so for several reasons:

  • Compared to Old Reddit, New Reddit is designed in a way that's much less amenable to third-party modifications in general. Old Reddit has a simple HTML structure with descriptive CSS class names like link for a link or tagline for a post tagline, which makes it easy for Reddit Deduplicator to locate and modify the relevant page elements. With New Reddit, CSS classes have obfuscated names like cZPZhMe-UCZ8htPodMyJ5. This makes it harder to find the right selectors for Reddit Deduplicator to use, and there's a possibility these class names might change arbitrarily as Reddit updates their frontend code, potentially causing the extension to stop working at any time.

    Not only is finding the right elements harder with New Reddit, but from my initial investigation it seems like it would be more difficult to cleanly modify the page to condense duplicates without disrupting the rest of the user interface.

  • New Reddit has more distinct page layouts that the extension would need to handle, for example the main view, user overview, and user posts view. With Old Reddit almost all pages have a uniform "site table" structure, the only exception (as far as I know) being the combined search page released in 2015.

  • With Old Reddit, getting post thumbnails is simple and straightforward, whereas with New Reddit getting a representative image for a post is more complex and there are several different variants that would need to be handled. In some views, posts don't have thumbnails so the add-on would need to use the larger media preview images, which could negatively impact the add-on's performance footprint.

  • Finally, the "infinite scroll" feature of New Reddit adds further complexity to the implementation and also poses some challenges for user experience (for example, if a later post is incorrectly identified as a duplicate of a much earlier post, the user might not be aware that they are missing something).

While none of these points is insurmountable, each one increases the complexity of implementing this enhancement. All in all, it would be a pretty sizable amount of effort, so I don't currently have plans to undertake this feature.

@nickgaya nickgaya added the enhancement New feature or request label May 2, 2021
@ghost
Copy link
Author

ghost commented May 2, 2021

with some React overlay?

@ghost
Copy link
Author

ghost commented May 2, 2021

For time being Reddit thumbnails have been a bit mess....
Get CORS https://chrome.google.com/webstore/detail/cross-domain-cors/mjhpgnbimicffchbodmgfnemoghjakai
remove the default rule and add such as i.redd.it* v.redd.it* ....
like that
image

@ghost
Copy link
Author

ghost commented May 2, 2021

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant