Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on PR for gratia #48

Open
7 tasks
nicholasjclark opened this issue Apr 25, 2024 · 0 comments
Open
7 tasks

Work on PR for gratia #48

nicholasjclark opened this issue Apr 25, 2024 · 0 comments

Comments

@nicholasjclark
Copy link
Owner

nicholasjclark commented Apr 25, 2024

Would likely require methods for:

  • vcov() with same arguments as vcov.gam()
  • update get_vcov() to return the Bayesian covariance matrix; shouldn't impact marginaleffects functionality
  • predict(object, type = 'terms')
  • predict(object, type = 'lpmatrix')
  • residuals(object, type = 'working')
  • weights(object)
  • smoothCon() and PredictMat() functions for gp() and dynamic() terms

... actually will be easier to

  1. use expand.grid() to get pred values for terms of interest. Accept an argument that allows multidimensional effects to be drawn either as heatmaps or in plot_predictions() style with faceting
  2. fix all other vars to representative row idxs by replicating a single entry in original data (only filling in the vars of interest). This will work with df or list types and the values for non-focal vars won't matter as we will use 'terms' predictions
  3. use predict(type = 'terms') to get partial contribution from effect of interest
  4. plot by sending to gratia::draw_smooth_estimates() and with modified multidimensional plot functions, i.e. plot_smooth.bivariate_smooth_facet() perhaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant